-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fixes to block switcher links, updates to text, fragments for JS and RN #5307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing authentication
…of scope for this PR, saving for Analytics updates overall).
…l PR feedback implemented.
…k for Flutter & mobile.
…om PR Reviews, and added of existing AWS resource links.
timngyn
pushed a commit
that referenced
this pull request
Apr 13, 2023
…ges, minor changes to page flow, and fixes to duplicated fragments (#5308) * update docs to include switch for CLI and existing resources when adding authentication * fix flutter page with proper "existing resources" code sample * fix to file type and minor visual improvement of code sample * add preamble after "Set Up Backend Resources" * add back in the 'Identify User' title/reference in directory.js (out of scope for this PR, saving for Analytics updates overall). * Updates to remove config/dependencies within Blockswitcher, additional PR feedback implemented. * space added for spell check error * New block add for 3 options (2 CLI and 1 Manual config) for Auth backend resources. * Further refinement of blocks and verbiage. Add 3rd Manual Config block for Flutter & mobile. * fixes to create new fragments for Flutter/iOS/Android pages * add change to js preamble * fixes to links that navigating to wrong platform, general feedback from PR Reviews, and added of existing AWS resource links. * Revert callouts * remove a comma that leads to invalid JSON string * revert "jsx" to "dart" for code block * fixes to block switcher links, updates to text, fragments for JS and RN * fixes that should mimic closed PR #5307, but not include unecessary files that were already merged in #5219 * Update src/fragments/lib/auth/js/getting-started-steps-basic-auth-react-native.mdx Co-authored-by: David McAfee <[email protected]> * remove duplicated "amazon-cognito-identity-js" * Add Studio option for block switcher within Auth > Getting Started pages * minor changes to block order and updates to Studio block text * Update src/fragments/lib/auth/android/getting_started/50_configureBackend.mdx add link per suggestion from @wrpeck Co-authored-by: Wesley P <[email protected]> * Update src/fragments/lib/auth/js/getting-started-set-up-backend-resources-react-native.mdx update to new formatting Co-authored-by: Bannon Tanner <[email protected]> * Update src/fragments/lib/auth/js/getting_started/10_setUpBackendResources.mdx Update to new formatting guidelines Co-authored-by: Bannon Tanner <[email protected]> --------- Co-authored-by: Abdallah Shaban <[email protected]> Co-authored-by: David McAfee <[email protected]> Co-authored-by: Wesley P <[email protected]> Co-authored-by: Bannon Tanner <[email protected]>
katieklein
pushed a commit
that referenced
this pull request
Apr 20, 2023
… minor changes to block names for Auth (#5387) * update docs to include switch for CLI and existing resources when adding authentication * fix flutter page with proper "existing resources" code sample * fix to file type and minor visual improvement of code sample * add preamble after "Set Up Backend Resources" * add back in the 'Identify User' title/reference in directory.js (out of scope for this PR, saving for Analytics updates overall). * Updates to remove config/dependencies within Blockswitcher, additional PR feedback implemented. * space added for spell check error * New block add for 3 options (2 CLI and 1 Manual config) for Auth backend resources. * Further refinement of blocks and verbiage. Add 3rd Manual Config block for Flutter & mobile. * fixes to create new fragments for Flutter/iOS/Android pages * add change to js preamble * fixes to links that navigating to wrong platform, general feedback from PR Reviews, and added of existing AWS resource links. * Revert callouts * remove a comma that leads to invalid JSON string * revert "jsx" to "dart" for code block * fixes to block switcher links, updates to text, fragments for JS and RN * fixes that should mimic closed PR #5307, but not include unecessary files that were already merged in #5219 * Update src/fragments/lib/auth/js/getting-started-steps-basic-auth-react-native.mdx Co-authored-by: David McAfee <[email protected]> * remove duplicated "amazon-cognito-identity-js" * Add Studio option for block switcher within Auth > Getting Started pages * minor changes to block order and updates to Studio block text * Update src/fragments/lib/auth/android/getting_started/50_configureBackend.mdx add link per suggestion from @wrpeck Co-authored-by: Wesley P <[email protected]> * Update src/fragments/lib/auth/js/getting-started-set-up-backend-resources-react-native.mdx update to new formatting Co-authored-by: Bannon Tanner <[email protected]> * Update src/fragments/lib/auth/js/getting_started/10_setUpBackendResources.mdx Update to new formatting guidelines Co-authored-by: Bannon Tanner <[email protected]> * updates to Auth block names, fix to React Native docs for Social Auth on Android * add update to Android * Updates to preamble wording to include additional options. * going with option #3 --------- Co-authored-by: Abdallah Shaban <[email protected]> Co-authored-by: David McAfee <[email protected]> Co-authored-by: Wesley P <[email protected]> Co-authored-by: Bannon Tanner <[email protected]>
katieklein
added a commit
that referenced
this pull request
May 9, 2023
…nd file references (#5433) * update docs to include switch for CLI and existing resources when adding authentication * fix flutter page with proper "existing resources" code sample * fix to file type and minor visual improvement of code sample * add preamble after "Set Up Backend Resources" * add back in the 'Identify User' title/reference in directory.js (out of scope for this PR, saving for Analytics updates overall). * Updates to remove config/dependencies within Blockswitcher, additional PR feedback implemented. * space added for spell check error * New block add for 3 options (2 CLI and 1 Manual config) for Auth backend resources. * Further refinement of blocks and verbiage. Add 3rd Manual Config block for Flutter & mobile. * fixes to create new fragments for Flutter/iOS/Android pages * add change to js preamble * fixes to links that navigating to wrong platform, general feedback from PR Reviews, and added of existing AWS resource links. * Revert callouts * remove a comma that leads to invalid JSON string * revert "jsx" to "dart" for code block * fixes to block switcher links, updates to text, fragments for JS and RN * fixes that should mimic closed PR #5307, but not include unecessary files that were already merged in #5219 * Update src/fragments/lib/auth/js/getting-started-steps-basic-auth-react-native.mdx Co-authored-by: David McAfee <[email protected]> * remove duplicated "amazon-cognito-identity-js" * Add Studio option for block switcher within Auth > Getting Started pages * minor changes to block order and updates to Studio block text * Update src/fragments/lib/auth/android/getting_started/50_configureBackend.mdx add link per suggestion from @wrpeck Co-authored-by: Wesley P <[email protected]> * Update src/fragments/lib/auth/js/getting-started-set-up-backend-resources-react-native.mdx update to new formatting Co-authored-by: Bannon Tanner <[email protected]> * Update src/fragments/lib/auth/js/getting_started/10_setUpBackendResources.mdx Update to new formatting guidelines Co-authored-by: Bannon Tanner <[email protected]> * updates to Auth block names, fix to React Native docs for Social Auth on Android * add update to Android * Updates to preamble wording to include additional options. * going with option #3 * update file reference for Angular tutorial, add what the final code block should look like for restaurants.component.ts * remove yarn.lock * update GraphQL Schema example to eliminate tutorial errors --------- Co-authored-by: Abdallah Shaban <[email protected]> Co-authored-by: David McAfee <[email protected]> Co-authored-by: Wesley P <[email protected]> Co-authored-by: Bannon Tanner <[email protected]> Co-authored-by: Katie Goines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://link.com)HTML:
<a href="https://link.com">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.